quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
15 stars 7 forks source link

Adjust solar thermal input in households with 50% #1396

Closed mabijkerk closed 8 months ago

mabijkerk commented 8 months ago

Issue In https://github.com/quintel/etsource/commit/f9a2ba437ad25db59804ce73bd412e1b71f551ea the graph structure of the solar thermal heater for households hot water was revised. This was part of https://github.com/quintel/etsource/pull/2997 and removed the need to have a child_share in the data pipelines:

~ child_share = SHARE("energy/residences_useful_demand_for_hot_water_for_houses_with_solar_heater_child_share", households_water_heater_solar_thermal)

This share was set to 50% for all datasets and was removed from the data pipelines in https://github.com/quintel/etdataset/pull/989. The input setting the share of solar thermal in its total potential however has remained unchanged: households_water_heater_solar_thermal_share. This effectively means that users previously set the potential of at maximum 50% of the useful demand for hot water. Now, with the same input, they set the potential of at maximum 100%.

Solution A migration needs to be added that adjust the input by setting it to 50% of its original value.

Example To demonstrate, II3050v2 Decentral initiatives on production gives 23 PJ of solar thermal heat production with the input set at 95%, while the same scenario on master gives 46 PJ with 95%.

Screenshot 2024-01-30 at 12 32 55 Screenshot 2024-01-30 at 12 33 36