search

quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
15 stars 7 forks source link

GQL #1418

Closed kaskranenburgQ closed 5 months ago

kaskranenburgQ commented 5 months ago

Improves GQL function INVALID_TO_ZERO

Goes together with PR Add GQL documentation #178

noracato commented 5 months ago

Hi! The method you updated is in the legacy department, which means at some point it was decided that this method was outdated. By doing this update, do you intend to bring back the method? If so, maybe we should move it out of the legacy code and see if we can find a good spot for it.

Although I have to say I'm not a big fan of the method. It basically ignores errors and returns 0 instead, which can easily lead to overlooked mistakes.

mabijkerk commented 5 months ago

I have not seen this GQL function being used in any gqueries and I was not familiar with it myself. Unless if we can come up with a relevant use case, I would conclude that we should remove this GQL instead. Do you agree @kaskranenburgQ? Can we simply remove a GQL function @noracato?

kaskranenburgQ commented 5 months ago

I think this function could be useful if you are preparing data. I don't think it is therefore necessary in GQL, since with our use of the language no data needs to be prepared. Removing instead of fixing the function would be a better idea in that case.

noracato commented 5 months ago

Can we simply remove a GQL function @noracato?

If it's not used in any queries, you should be safe to remove it. Make sure to check the specs to see if you should also remove the tests for it!

Removing instead of fixing the function would be a better idea in that case.

Agreed! Always nice when we can declutter!

mabijkerk commented 5 months ago

@kaskranenburgQ can you remove the GQL function and any accompanying specs from ETEngine and the documentation?