quintel / etengine

Calculation engine for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
14 stars 7 forks source link

coal ultra super-critical powerplant efficiencies don't add up to 100% #425

Closed markquintel closed 12 years ago

markquintel commented 12 years ago

And same problem holds when changing the fuel:

ChaelKruip commented 12 years ago

Assigned @cjlaumans as this is his expertise.

cjlaumans commented 12 years ago

Reassigning back to you @ChaelKruip because this is I think due to the fact that losses aren't updated in the input statement while the efficiencies are.

For the start scenario the efficiencies do add up to 100%, only if you change the percent share of co-firing do you get that they do not add up to 100%. So this is due to the losses not being updated in the input statements.

ChaelKruip commented 12 years ago

I have changed the input statement to include 'loss' but this does not seem to have any effect. See the code below"

query: |-
 conversion_efficiency_wood_pellets = V(energy_power_ultra_supercritical_coal, electrical_efficiency_when_using_wood_pellets);
 conversion_efficiency_coal = V(energy_power_ultra_supercritical_coal, electrical_efficiency_when_using_coal);
 x = USER_INPUT() / 100.0;
 conversion_efficiency_new =  x * conversion_efficiency_wood_pellets + (1 - x) * conversion_efficiency_coal;

 conversion_efficiency_wood_pellets_chp = V(energy_chp_ultra_supercritical_coal, electrical_efficiency_when_using_wood_pellets);
 conversion_efficiency_coal_chp = V(energy_chp_ultra_supercritical_coal, electrical_efficiency_when_using_coal);
 conversion_efficiency_chp_new =  x * conversion_efficiency_wood_pellets_chp + (1 - x) * conversion_efficiency_coal_chp;

 EACH(
    UPDATE( OUTPUT_SLOTS(V(energy_power_ultra_supercritical_coal), electricity), conversion, conversion_efficiency_new),
  UPDATE( OUTPUT_SLOTS(V(energy_power_ultra_supercritical_coal), loss), conversion, "1-conversion_efficiency_new"),
  UPDATE( INPUT_SLOTS(V(energy_power_ultra_supercritical_coal), wood_pellets), conversion, x),

    UPDATE( OUTPUT_SLOTS(V(energy_chp_ultra_supercritical_coal), electricity), conversion, conversion_efficiency_chp_new),
  UPDATE( OUTPUT_SLOTS(V(energy_chp_ultra_supercritical_coal), loss), conversion, "1-conversion_efficiency_chp_new-V(energy_chp_ultra_supercritical_coal, heat)"),
  UPDATE( INPUT_SLOTS(V(energy_chp_ultra_supercritical_coal), wood_pellets), conversion, x)
 )

@hasclass @dennisschoenmakers @antw Could it be possible that the output-slot of the 'loss' carrier is treated differently then the other carriers in etengine?

ChaelKruip commented 12 years ago

I have created a new branch for this issue (and https://github.com/dennisschoenmakers/etmodel/issues/998 which is related) with the following commit: https://github.com/dennisschoenmakers/etsource/commit/56f3e8f92dd06146e90203ca8489852f1559be2c

dennisquintel commented 12 years ago

assigned @antw

ChaelKruip commented 12 years ago

Assigned to @antw

dennisquintel commented 12 years ago

Assigned myself. This update gquery is too much of a mess now and too much happens here. We need to clean this up and first find a proper design for changibg efficiencies with carriers. Will need help of @ChaelKruip, @antw and possibly more.

ChaelKruip commented 12 years ago

Removing milestone "Deploy Aug. 2012".

dennisquintel commented 12 years ago

Related to #364

dennisquintel commented 12 years ago

Closing this ticket. @antw is working on #364