CSV importer should check for negative numbers

quintel / etlocal

Regional data analysis tool for the Energy Transition Model

https://data.energytransitionmodel.com/

MIT License

3 stars 2 forks source link

CSV importer should check for negative numbers #164

Open michieldenhaan opened 5 years ago

michieldenhaan commented 5 years ago

Currently it is possible to add negative numbers (and maybe non-numeric values as well?) to the database using the CSV import feature. This causes datasets to break when exporting to ETSource. It would be nice if the importer throws an error when the CSV contains negative/non-numeric values (except for the geo_id and name fields which do contain non-numeric values)

github-actions[bot] commented 3 months ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

mabijkerk commented 3 months ago

@noracato do we even still have a CSV importer feature?

noracato commented 3 months ago

Yes, the CSV importer is used for all the data migrations. I think it wouldn't hurt to add some extra validators to it at one point.