search

quintel / etlocal

Regional data analysis tool for the Energy Transition Model
https://data.energytransitionmodel.com/
MIT License
3 stars 2 forks source link

Dataset Province of Noord-Holland update to 2022 #542

Closed kaskranenburgQ closed 3 weeks ago

kaskranenburgQ commented 1 month ago

This PR updates the province of Noord-Holland to 2022. In this update we mostly took the 2019 dataset and updated the most notable changes in Klimaatmonitor. This effort is therefore useful for new studies with this dataset.

Goes together with: https://github.com/quintel/etsource/pull/3135

kaskranenburgQ commented 1 month ago

@noracato Alright! Will do that.

kaskranenburgQ commented 1 month ago

With the removal of the changes for the file importable_commit.rb the migration will no longer run. The error message as described in #545 pops up. When I run the migration with the changes in importable_commit, it stated that the columns 'country' and 'name' where not in the edtiable attributes of the dataset and so it skipped over these keys . One would think that leaving them out of the migration with the regular code for importable_commit.rb would then be the solution. If you do an error pops up stating that 'country' and 'name' are missing mandatory headers, so the migration does not run. Therefore I'm not sure what to do anymore. @noracato From this description, do you have an idea about what's going on.

kaskranenburgQ commented 4 weeks ago

Thanks to @louispt1 the issue is fixed! We can go ahead with the merge!