Open kndehaan opened 3 weeks ago
Because we appended the EB filenames with "energy_balance_enriched" we need to update the links anyway. Perhaps this is also what @louispt1 is referring to in https://github.com/quintel/etlocal/issues/559.
I'm fine with option 1 to make the commit message more generic. Ideally, we would refer to the dataset pipeline instead of the files on ETLocal. The files on ETLocal are only for ETLocal to be able to read the data, so this doesn't give users a lot of additional insights. Since only CH, NO and RS have nicely documented pipelines on ETDataset now, this is something we might do in the future (and we can discuss it in the "Streamlining datasets" project). Let's keep it simple for now!
Finally, I'd recommend renaming the attribute in the interface_elements that specifies that a key should be read from the EB. It is now marked with entso
, which does not make sense. I would rename it to energy_balance
to facilitate both Europe and World EBs.
Various keys in ETLocal are calculated with the EB() method where data is obtained from the energy balance. The default commit message used for these keys is "Value sourced from the Eurostat energy balance", however it is not always the case that the energy balance is obtained from Eurostat. Therefore, the default description should be changed.
I see two options:
dataset_source
set toentso
) indicating whether an energy balance is sourced from Eurostat, e.g. indicating in the data.csveurostat_eb
isTrue
. IfFalse
, generic descriptions for the commit messages can be applied. This requires adding this new attribute to all country datasets that use the EB() method, as well as changes in the setup of the local files and add generic description for non-eurostat EB.@mabijkerk @kaskranenburgQ let me know what you think.