search

quintel / etm-esdl

http://esdl.energytransitionmodel.com/api/v1/
1 stars 0 forks source link

Update create_with_context #82

Closed Charlottevm closed 1 year ago

Charlottevm commented 1 year ago

The create_with_context should be more standardized to be able to read different ESDL's. Goal is to be able to read the ESDL's provided in the micro-case, see \Projects/Active/537 Multi Modelling voor Integrale Besluitvorming (RVO)/03 Project/ESDL/Micro/EPS - Tholen Welgelegen (5) (--> 'pand_huidig' & 'pand_scenario')

  1. Make a plan for technical improvements to this endpoint in order to standardise this endpoint (aka remove all (hardcoded) gridmaster 'hacks/descriptions'), execute if you need less then 0.5 day, otherwise discuss
  2. Make a list of everything that needs to be added to the asset list / mapping / parsers in ESDL to be able to read the ESDL provided by the micro-use case, discuss / assign at will
noracato commented 1 year ago

The ESDLs you mentioned are missing a date instance, that's mainly why they cannot be parsed by the create_with_context.

For example:

<date xsi:type="esdl:InstanceDate" date="2050-01-01T00:00:00.000000"/>

I added some fake dates in the fixtures like this, on the branch create-context-2023 https://github.com/quintel/etm-esdl/blob/b07e8a235171671420aabe888bb5de2090b6e774/tests/fixtures/pand_huidig.esdl#L138-L140