search

quintel / etm-esdl

http://esdl.energytransitionmodel.com/api/v1/
1 stars 0 forks source link

Optionally supply a scenario ID to `create` to update a scenario instead #94

Closed noracato closed 1 year ago

noracato commented 1 year ago

Quick fix. We should actually:

Closes #93

redekok commented 1 year ago

Could it be the case that the app has some troubles with authentication rights? I think it won't allow me to modify a randomly created scenario because I'm not authored to (without valid credentials)?

image
noracato commented 1 year ago

You can not communicate with scenario's you made when you were logged in indeed. Running ETE locally solves this. But yes, we need to add SSO support to the app indeed!

redekok commented 1 year ago

The KPI handler also caused some trouble which I've fixed in https://github.com/quintel/etm-esdl/commit/71c203284af50b0e9ebdb8444b11b0d93446e727. After, I managed to update an existing ETM scenario based on an ESDL file. However, when I try this twice in a row (with the same API session ID) I get the following error:

image

@noracato is this something we should fix before merging this PR?

noracato commented 1 year ago

Ah, interesting! This seems to be an ETEngine issue, as the engine's endpoint for setting or updating the ESDL file is the same one. I'll create an issue there and check it out!

redekok commented 1 year ago

LGTM now! 💯