search

quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
26 stars 12 forks source link

Wind turbine potential exploration in PICO is not working #3763

Open marliekeverweij opened 3 years ago

marliekeverweij commented 3 years ago

It says that it is phased out as of March 1 2021

What shall we do? Can it be fixed or shall we remove it?

Screenshot 2021-07-15 at 16 24 46

Spotted by @mabijkerk

noracato commented 3 years ago

We can't solve it ourselves unfortunatly.

We grab some of geodans supplied javascript files to render the PICO module. And in there, in the initPicomap() function, they us a protocol to load map layers called TMS. However, as the warning in the image shows us, they can't load the map layers through TMS anymore and should switch to WMTS instead.

So we have two options: ask geodan to update the protocol (should not be that hard, according to PDOK where they get the map from), or indeed drop it if we feel like it's not worth the hussle...

marliekeverweij commented 3 years ago

So we have two options: ask geodan to update the protocol (should not be that hard, according to PDOK where they get the map from), or indeed drop it if we feel like it's not worth the hussle...

Alright! I like the feature, so I think asking Geodan is a good idea. What do you think @redekok ?

redekok commented 3 years ago

I like the feature as well, though I think it's a pity it's not very known among our users. Since the PICO viewer service will be discontinued, I'm not sure if we should go through with this. I think it would be a good idea to contact Geodan and see if we could build this feature upon their new Energietransitie-viewer. Depending on whether that's possible and how much work that would be, we can decide whether to keep this feature in the air? Our contact at Geodan switched jobs though so we'll have to search for the right person to contact.

redekok commented 3 years ago

Let's remove this feature since the PICO functionality is deprecated as well. For now (i.e., coming deploy) we could remove the url from the slide description. Would you have time to pick this up @noracato ?

github-actions[bot] commented 2 years ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.