search

quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
25 stars 12 forks source link

Sankey losses seem out of place #4194

Open Charlottevm opened 7 months ago

Charlottevm commented 7 months ago

In an empty scenario for Drenthe the sankey portrays large losses while these do not occur in the scenario (see below).

afbeelding

github-actions[bot] commented 5 months ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

github-actions[bot] commented 3 months ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

mabijkerk commented 3 months ago

@kaskranenburgQ or @kndehaan could you look into this at some point?

kaskranenburgQ commented 3 months ago

This issue exists due to the absence of non biogenic waste in the Sankey chart. Since Drenthe has a high percentage of power production via waste, this becomes clear in this dataset. If we were to add non-biogenic waste, the sankey would add up: Screenshot 2024-05-29 at 09 37 37

The losses of non biogenic waste are at the moment calculated within the losses accounted to biomass products, within the query conversion_loss_biomass_products_to_electricity. In this query, conversion_loss_waste_mix_to_electricity is not multiplied by the share of biogenic waste in the waste mix.

Because of this we see extra losses in the picture by @Charlottevm.

@mabijkerk I can't remember the reason why we did not add non-biogenic waste to the sankey chart, both a label, a color, and queries are ready for this carrier. Do you?

Furthermore, since the query conversion_loss_biomass_products_to_electricity does not seem to be used correctly and is used in the sankey download, we should investigate whether this is the case.

mabijkerk commented 3 months ago

I can't remember the reason why we did not add non-biogenic waste to the sankey chart, both a label, a color, and queries are ready for this carrier. Do you?

I think we have simply glanced over it?

github-actions[bot] commented 1 month ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.