quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
25 stars 12 forks source link

Need to revise the working of the dependent_on attribute in etdataset #4198

Open kaskranenburgQ opened 5 months ago

kaskranenburgQ commented 5 months ago

An error occurs while trying to make changes to the space heating & hot water in the IP2024 scenario's.

The error occurs due to the households_heater_crude_oil_share that is set by the creators of the scenario with the API.

In the scenario, the share is set to 0.1, see screenshot underneath. Most likely this is copied from the base nl2019 dataset.

Screenshot 2024-01-29 at 17 36 22

In the dutch dataset this share is hidden for the user since it is assumed that this technology will not be used in the Netherlands in the future.

If the user would want to change this share in the GUI, an error occurs. This occurs since the model wants to balance the sliders to 100, this is impossible since the oil_share is set to 0.1 .

Notifying @mabijkerk , will pick this up myself.

github-actions[bot] commented 3 months ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.

mabijkerk commented 3 weeks ago

The IP2024 scenarios now still crash when trying to make changes to the space heating technologies. This is caused by the households_heater_crude_oil_share: 0.1 which is hidden in ETModel but set using the API. The autobalancer of ETModel then fails to sum to 100.

Fixing the underlying issue may need some discussion on how to best to do so right @noracato? Depending on the outcome of the discussion this might be picked up by @louispt1. The short-term solution for these scenarios is to simply remove the input from the relevant scenarios.

kaskranenburgQ commented 3 weeks ago

I removed the share from the preset scenario's on both pro and beta. Now users should be able to change the sliders again.

mabijkerk commented 3 weeks ago

Thanks @kaskranenburgQ, good work!