Sankey should include solar and wind with battery

[MartLubben]

"Zon op land met batterijsysteem" and "Op land met batterijsysteem" are not included in the Sankey.

[MartLubben]

When al turbines include batteries, it does not show in the sankey als wind. Same is true for solar fields.

[mabijkerk]

Thanks for this @MartLubben, well-spotted!

[kaskranenburgQ]

I have examined the issue. I would expect that these energy flows would be implemented in the conversion_from_solar_electricity_to_electricity & conversion_from_wind_electricity_to_electricity queries, both the nodes for solar (energy_battery_solar_electricity) and wind (energy_battery_wind_electrcity) with batteries fall under the electricity_production group. However, these queries filter based on solar_radiation_input_conversion and wind_input_conversion respectively. Both these nodes do not convert wind or solar to electricity since this conversion happens in energy_battery_solar_pv_solar_radiation (for solar) and energy_battery_wind_turbine_inland (for wind).

I see 2 options to fix this issue:

1. Remove the group 'electricity production' from the energy_battery_xxx_electricity nodes and place them on the nodes where the conversion takes place.
2. Create a new query, in which the electricy_output of the nodes is taken. This is than added to the conversion_from_xxx_to_electricity nodes.

@mabijkerk Do you agree? And which option would have your preference?

[mabijkerk]

I think the reason why the energy_battery_{SOURCE}_electricity nodes have the group electricity_production is that we want the main model to view the always on battery parks as a single system i.e. a black box, even though we model all the components. That is also why the nodes have the group merit_order_csv_include and the nodes energy_battery_{PRODUCER} have the group merit_order_csv_exclude.

As becomes clear through this issue, this approach has its downsides. Another downside is that when we write queries using merit_order attributes, the exceptions created by the groups are not taken into account, because the merit order attributes are placed on the energy_battery_{PRODUCER} nodes.

I think this is a relevant issue for the implementation of hybrid offshore wind as well. I suggest we discuss this issue in a short meeting for that project.

[github-actions[bot]]

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.