search

quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
26 stars 12 forks source link

Need to fix featured scenario's for West-midden Brabant #4241

Closed kaskranenburgQ closed 4 months ago

kaskranenburgQ commented 5 months ago

On the website we have 2 featured scenario's for West-midden Brabant.

Screenshot 2024-04-15 at 16 02 22

If you click on one of them, nothing happens. Since no introduction page for the featured scenario opens, it is not possible to remove them.

After a short consultation from the @noracato we discovered that this is possibly broken since the area code of the scenario does no longer exist.

A migration thus needs to be written which replaces the area code for all scenario's.

Notifing @mabijkerk, will pick this up myself.

mabijkerk commented 5 months ago

I wonder whether these scenarios are still relevant enough to keep them as featured scenarios.

mabijkerk commented 5 months ago

To add to my previous comment, these scenario likely refer to the region code RGNB01 (see the Dataset Manager). This region is still maintained on ETLocal but no longer available on ETSource (see the datasets).

Writing a migration therefore will likely have no effect, since the region is no longer available. The two options are then:

  1. Remove the featured scenarios
  2. Re-install the region in ETSource using the available data on ETLocal

Finally, notifying @noracato, it would be useful at some point to add some error routing for this. Something like: "The region modelled in this scenario is no longer available in the model, contact Quintel for questions". What do you think?

mabijkerk commented 5 months ago

After the discussion on the general channel I would go for option 1. Specifically, I would only "un"feature the scenario and not remove the scenario altogether. Additionally, I would write a mechanical turk test that runs a single query for each featured scenario, just so we know that each featured scenario can be opened. Can you pick this up @kaskranenburgQ?

noracato commented 5 months ago

it would be useful at some point to add some error routing for this

For the featured scenarios that would be a great idea. To keep the featured page, but without the open button.

Also handy because currently we run into the problem that, without being able to view the scenario's featured page, there is no way to press the 'unfeature' button anymore. I have to go manually into the database now to unfeature it...

mabijkerk commented 5 months ago

I have to go manually into the database now to unfeature it...

Could you pick this up at some point @noracato?