search

quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
33 stars 14 forks source link

Separate units column #4295

Closed louispt1 closed 4 months ago

louispt1 commented 5 months ago

As requested in #3862, units have now been separated into another column. This is what it looks like:

image

A more robust solution might externalise the js in this _table_template to a helper method. I had a bit of trouble with this because I would need to make the html template a .erb to use the helper methods and there were some rendering issues going down that route.

This works so maybe it's easier to leave it as is 😄 .

Closes #3862

mabijkerk commented 5 months ago

@louispt1 what about translations for the word "Unit"? In Dutch this would be "Eenheid".

louispt1 commented 5 months ago

@louispt1 what about translations for the word "Unit"? In Dutch this would be "Eenheid".

Fixed

kndehaan commented 5 months ago

I also had a quick look, looks very good! Would it be possible to move the "Unit" column to the front? So before the first data column (in this case before "2019" column).

louispt1 commented 5 months ago

I also had a quick look, looks very good! Would it be possible to move the "Unit" column to the front? So before the first data column (in this case before "2019" column).

Fixed now :)

kndehaan commented 5 months ago

Looking good!