search

quintel / etmodel

Professional interface of the Energy Transition model.
https://energytransitionmodel.com/
MIT License
33 stars 14 forks source link

Switching from kaminary to Pagy in ETModel #4317

Open louispt1 opened 3 months ago

louispt1 commented 3 months ago

This PR is to switch fro Kaminari to Pagy in ETModel only. Kaminari still seems to be working quite well in ETEngine so there may not be any reason to change just yet - except for Pagy boasting r.e. their memory usage, speed etc .... There is a migration guide which proved fairly useful.

Everything works! The only thing is that the styling is a bit different from how it was before.

Before: image

After: image

Edit - made it much closer to the original now. image

In theory you could customise this forever, so if there is something that would be nice to have or something you really don't like about the current implementation I'm very happy to fiddle with it.

Closes #4307

louispt1 commented 3 months ago

Having looked at this a bit more, I think it may be affecting the api requests? saved_scenarios_spec and transition_paths_spec are both unhappy - do you know what could be causing this @noracato?