search

quintel / etmoses

Online decision support tool to create local energy situations for neighbourhoods, cities and regions with a time resolution of 15 minutes created and maintained by Quintel – Not maintained
https://moses.energytransitionmodel.com
MIT License
11 stars 3 forks source link

Topology/save validation #1462

Closed grdw closed 7 years ago

grdw commented 7 years ago

Fixes: #1458

antw commented 7 years ago

I know it's a work-in-progress (which I guess is why you want this merging into the "new-topology-editor" branch?)... One small thing I noticed: on the LES topology page – /testing_grounds/:id/edit – if there's a validation error on a node the "Save" button is still disabled and the spinner appears:

screen shot 2016-09-29 at 11 01 38

I do like what I see though, the new editor is looking great. :+1:

grdw commented 7 years ago

which I guess is why you want this merging into the "new-topology-editor" branch

Yes. It's not yet in a stable state.

if there's a validation error on a node the "Save" button is still disabled and the spinner appears:

Thanks for checking.

grdw commented 7 years ago

if there's a validation error on a node the "Save" button is still disabled and the spinner appears:

I fixed that problem 👍