quintel / etmoses

Online decision support tool to create local energy situations for neighbourhoods, cities and regions with a time resolution of 15 minutes created and maintained by Quintel – Not maintained
https://moses.energytransitionmodel.com
MIT License
11 stars 3 forks source link

User may customise heat capacity per connection #1521

Closed antw closed 7 years ago

antw commented 7 years ago

This PR adds an input on the testing ground "general" form allowing the visitor to customise the central heat buffer volume per heat-connection. Defaults to nil/NULL, which in turn will default to 10kWh in Network::Builders::Heat (so that if we change the default in the future, older LESes won't be stuck with an out-of-date value).

screen shot 2016-10-24 at 14 25 50 screen shot 2016-10-24 at 14 25 59

I think this field would be more at home on the "Heat source list" tab, but I'm not sure if that's possible? All the fields on that page relate to the heat source list, while this is a column on the testing_grounds table. I think this is not a deal-breaker.

@grdw Can you take a look at this when you have the time? Thanks!

Ping @ChaelKruip

grdw commented 7 years ago

I have no idea how to properly test this. It doesn't cause any errors when changing the number, saving works, all the basics still function + the specs succeed 👍 . I don't see any difference in my heat calculation but that can be because I don't know exactly what to look for.

grdw commented 7 years ago

I think this field would be more at home on the "Heat source list" tab, but I'm not sure if that's possible?

It could be. If you edit the testing_grounds/edit.html.haml and add another form to the heat source list pane it will probably work 👍.

antw commented 7 years ago

I have no idea how to properly test this.

We don't have specs for the network calculation, so you'll have to take my word for it. 😆 Here are some screenshots from a local LES:

0kWh per connection (no buffering occurs):

screen shot 2016-10-24 at 16 53 26

No value set (defaults to 10kWh):

screen shot 2016-10-24 at 16 53 14

100kWh per connection:

screen shot 2016-10-24 at 16 52 59

grdw commented 7 years ago

so you'll have to take my word for it.

expect(true).to eq(true)
antw commented 7 years ago

expect(true).to eq(true)

So, about that... 😱

(my bad!)