quintel / etmoses

Online decision support tool to create local energy situations for neighbourhoods, cities and regions with a time resolution of 15 minutes created and maintained by Quintel – Not maintained
https://moses.energytransitionmodel.com
MIT License
11 stars 3 forks source link

Secondary heat infrastructure costs not represented in business case #1586

Closed DorinevanderVlies closed 7 years ago

DorinevanderVlies commented 7 years ago

Description

This LES only has technologies attached to node "1 - flat". I just added heat technologies (all district heating) to this node. No investment and O&M costs attached to these technologies.

In the heat assets tab I assigned 1000 euro per connection to all 54 connections. The lifetime is 10 years. So I would expect (1000 euro/10year lifetime *54 units = )5400 euro depreciation costs of stakeholder 1. However, there are no depreciation costs for stakeholder 1.

Screenshots

image

image

notifying @AlexanderWirtz

grdw commented 7 years ago

I'll have a look.

grdw commented 7 years ago

If I understand this issue correctly the Customer Ac1 should receive depreciation costs?

DorinevanderVlies commented 7 years ago

Yes, indeed. Or extra outgoing costs, but this doesn't seem to be the case as well. To test this I added some 0's to the investment expecting a change in the business case. However the business case didn't change when the investment of secondary heat infrastructure was changed.

grdw commented 7 years ago

I see what's going on here. Appearantly the number_of_units for secondary Heat Assets is always 0 and I also know why. Am fixing it.

grdw commented 7 years ago

Ok, that was one. But there's another thing going on here. The topology also contains the Customer AC1 but that calculation returns NaN for a reason. Probably because the technical_lifetime is not set? If you could check that out.

DorinevanderVlies commented 7 years ago

I found technical lifetimes and investment costs defined as 0 for the buffer. This could be a problem. It shoudn't really be a problem right?

Are the two LESses below working properly?

LES with technical lifetimes and initial investment and O&M left emtpy

LES with technical lifetime of 30 years even when initial investment and O&M costs are non-defined (empty)

grdw commented 7 years ago

I found technical lifetimes and investment costs defined as 0 for the buffer. This could be a problem. It shoudn't really be a problem right?

No that's not the problem in this case. It's about the nodes in the electricity topology that belong to the stakeholder Customer Ac1 (those attributes here). I think its' (node 1 - flat 5 - flat 9 - flat).

DorinevanderVlies commented 7 years ago

Those are indeed that nodes beloning to stakeholder 1. I have a feeling that this NAN has been an issue before, is it related to #1530?

The attributes like investment cost, technical lifetime etc are indeed empty for most nodes in this LES. My preference would be to have the option to leave them empty when they're not relevant (like in this LES).

image

grdw commented 7 years ago

[..] before, is it related to #1530?

Well, not really. The values are now correctly null which is fine, but you can't calculate with null. We could set defaults for those values but that's a bit odd. 🤔 However, I also think the correct outcome of the topology_costs for Customer Ac1 should be 0 instead of NaN. I guess that can be easily done by setting the technical_lifetime default to 1 but I need to try that out.

grdw commented 7 years ago

Oops, I was checking out the wrong costs. It are the TechnologyCosts ...

DorinevanderVlies commented 7 years ago

So the heat infrastructure issue is solved, right? :smiley:

grdw commented 7 years ago

screen shot 2016-12-15 at 14 43 27

Found it! 👍

grdw commented 7 years ago

About secondary heat assets: I made a pull request with the fix for the secondary heat assets.

About technology costs: However, the technologies in question had to be given a technical_lifetime for this to work:

screen shot 2016-12-15 at 15 53 27

I found out that locally one of them had 0 years which is unfortunately possible to enter as a value but impossible to use for the calculation of the initial costs of the business case. (So this should be validated properly).