search

quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Change unit type for inputs with boolean values #2944

Closed thomas-qah closed 9 months ago

thomas-qah commented 9 months ago

What?

This PR changes the unit type for inputs with boolean values from x to bool so they can be properly recognized and acted upon by the rest of the application stack (i.e. etengine).

Why?

As described in this and this issue boolean values are currently not handled properly: they were not validated properly and their value was interpolated and recalculated for scenarios in transition paths. Both of these issues are fixed through PR https://github.com/quintel/etengine/pull/1358. That PR depends on the changes in this PR to work properly.

How?

The unit value are simply changed from x to bool in the input definitions for the following inputs:

heat_storage_enabled
merit_order_subtype_of_energy_power_nuclear_uranium_oxide
settings_enable_merit_order
settings_enable_storage_optimisation_energy_flexibility_flow_batteries_electricity
settings_enable_storage_optimisation_energy_flexibility_hv_opac_electricity
settings_enable_storage_optimisation_energy_flexibility_mv_batteries_electricity
settings_enable_storage_optimisation_energy_flexibility_pumped_storage_electricity
settings_enable_storage_optimisation_households_flexibility_p2p_electricity
settings_enable_storage_optimisation_transport_car_flexibility_p2p_electricity

Closes #1321 Closes quintel/multi-year-charts#31