quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Update cost queries to match the new cost export structure #3008

Closed redekok closed 4 months ago

redekok commented 4 months ago

This PR renames and restructures costs queries to match the new structure of the costs export functionality. It also fixes minor bugs.

Background The new costs export serializer finds queries with the following suffixes:

Queries within all infrastructure components (heat, electricity, gas, hydrogen) have been changed to match these suffixes.

Changes Heat infrastructure costs

Electricity infrastructure costs Existing query names were inconsistent with other costs queries. For example, lv_net_additional_capital_costs actually referred to additional CAPEX = capital costs + depreciation costs.

These and other inconsistencies have been addressed:

Gas infrastructure costs Add layer of _annualised_costs query

Heat delivery system costs

Carrier costs Add layer of _annualised_costs query

Hydrogen storage and insulation costs Add layer of _annualised_costs and _capex queries

Insulation costs buildings & households

CO2 emissions costs Add separate ccus and co2_emissions_costs queries.

Bug fixing

mabijkerk commented 4 months ago

I'm having a hard time following the new structure for CCUS costs queries:

What I'm struggling with:

Most importantly, based on the query titles I have no idea what's what. When is something "CO2", when is something "CCUS". It feels like it's different in the data-export and different in the queries and then again different in the frontend, where it is "CCUS costs" and "CO2 emissions costs".

mabijkerk commented 4 months ago

I noticed that the insulation costs do not have a capital costs component. @KoenvanB noted this as well and added that the source data may already have applied some kind of annualisation. This is something to note for further investigation.

mabijkerk commented 4 months ago

Another point to note is that our gas infrastructure costs 'calculation' is extremely limited. It does not even change based on changes in demand or supply of gas. Also something to note for further investigation.

mabijkerk commented 4 months ago

The queries for heat infrastructure are rather numerous, making it hard to review (and maintain) them. This is something to note for further improvements.