quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Queries for residential heating technology chart #3014

Closed KoenvanB closed 3 months ago

KoenvanB commented 3 months ago

This PR adds queries for the residential heating technology chart. See PR #4216 in ETModel. The PR includes:

Discussion

mabijkerk commented 3 months ago

In general, the queries are looking good. Nice work @KoenvanB!

I think it would be very useful to write a short mechanical turk spec for this. For example, one test to check if all the queries per technology sum to the number of units of that technology and one test to check if all the queries in the chart sum to the total number of residents.

Is the systematic naming of the queries in line with existing queries? E.g. is a distinction required between 'households' and 'residences'?

I might have a small preference in this case to write all queries like this: number_of_houses_{YEAR}_{HEATING_TECHNOLOGY}. This reflects the node names which are e.g., terraced_houses_before_1945. I'm not exactly sure nor happy with the difference between residences and houses. Maybe @Charlottevm can weigh in on this?

KoenvanB commented 3 months ago

@mabijkerk I have

That makes this PR ready to merge