Open mabijkerk opened 6 months ago
This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.
Background In the molecule graph, industry nodes determine their CO2 flow based on hardcoded values for the
co2_conversion_per_mj
of the selected carrier. For example for in the industry_final_demand_for_chemical_fertilizers_network_gas_co2 node:Issue This is problematic for a few reasons:
co2_conversion_per_mj
. The same applies to crude oil, which may be a mix of several carriers, like bio oil etc.The result is that the flows in the molecule graph do not match the CO2 emission factors of the associated carriers in the energy graph.
Solution Instead of hardcoded values, we would need to implement a way in which the molecule graph can retrieve these values dynamically. When a region has a different emission factor, or when a user changes the composition of an aggregate carrier, this needs to be accurately reflected in the molecule flows.
Note, this has already been attempted in some way, see https://github.com/quintel/etsource/commit/1d67bd923982b341e7b35daffdad5a2f7e3c4f16. However, instead of taking the carrier value, we might take the
weighted_carrier_co2_per_mj
of the relevant energy node as it is likely to produce the desired result.Notifying @kaskranenburgQ and @kndehaan