quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Add specs for document validation #3082

Open kaskranenburgQ opened 4 months ago

kaskranenburgQ commented 4 months ago
mabijkerk commented 4 months ago

Check whether wacc that is inside the node file is equal to the wacc group that is given.

From #3033. Closing that issue as it's covered here.

Energy nodes may have wacc attribute that is set at either 2%, 3%, 4% or 7%. Nodes that have a wacc attribute should have a matching node group wacc_proven_tech, wacc_unproven_tech etc.

We should write Semaphore test that, for all energy nodes in the graph, checks that for those with a wacc attribute, the value of the attribute and the label of the group align.

mabijkerk commented 4 months ago

Check whether the inputs and outputs for all carriers add up to 1.0 in the node files.

For some node exceptions would have to be made, notably the hydrogen and gas burners with efficiencies based on LHV > 100%. Preferably, if a spec is added to test this, the relevant nodes will be assigned a group that actively exempts them from this spec.

github-actions[bot] commented 1 week ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.