quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
13 stars 8 forks source link

Solar thermal and geothermal custom curve full load hours don't work #3119

Open kndehaan opened 2 months ago

kndehaan commented 2 months ago

When uploading a custom curve for solar thermal and geothermal full load hours, full load hours of the relevant nodes are not updated.

For solar thermal, part of the issue is that energy_heat_solar_thermal in the flh_of_solar_thermal input is outdated. These nodes are now subdivided in energy_heat_solar_ht_solar_thermal, energy_heat_solar_mt_solar_thermal, energy_heat_solar_lt_solar_thermal.

- query = UPDATE(V(energy_heat_solar_thermal, buildings_space_heater_solar_thermal, households_water_heater_solar_thermal), full_load_hours, USER_INPUT())
- priority = 3
- unit = hours
- update_period = future

Similarly, for flh_of_geothermal_heat the node energy_heat_well_geothermal is outdated. We currently have the nodes: energy_heat_well_deep_ht_geothermal, energy_heat_well_deep_mt_geothermal, energy_heat_well_shallow_lt_geothermal (and energy_heat_well_shallow_heatpump_mt_geothermal?) to be updated here.

However, when I implement the correct node names, the full load hours still don't update. So there is another problem here which should be divided in further.

github-actions[bot] commented 4 days ago

This issue has had no activity for 60 days and will be closed in 7 days. Removing the "Stale" label or posting a comment will prevent it from being closed automatically. You can also add the "Pinned" label to ensure it isn't marked as stale in the future.