search

quintel / etsource

Data source for the Energy Transition Model
https://energytransitionmodel.com/
MIT License
12 stars 8 forks source link

Queries used for electricity production table and default /supply chart should be cleaned up and made consistent with each other and internally... #53

Closed dennisquintel closed 12 years ago

dennisquintel commented 12 years ago

Now a lot a groups are just a bit different.

cjlaumans commented 12 years ago

The inconsistency is because different converter groups are being used between different queries in both the 'Electricity Production' chart and 'Power Plant Properties' HTML table. In particular the two 'largest' groups are:

There are many problems with this:

1) Where possible we should avoid defining groups in the queries 2) The groups aren't equal at the moment. Q(electricity_producing_converters) contains micro_chp_space_heating_households and collective_gas_chp_households_energetic which are not in G(electricity_production). And G(electricity_production) contains G(electricity_production) contains Coal CHP industry, diesel_generator_energy_energetic, and gas_turbine_energy_energetic which aren't in Q(electricity_producing_converters).

My suggestion would be to update G(electricity_production) and use it where possible to maximize consistency.

@AlexanderWirtz @WvanLelyveld for comments ?

AlexanderWirtz commented 12 years ago

update!

cjlaumans commented 12 years ago

I refactored the queries used in the power plant properties table. Many queries had hard coded which converters are used, making it easy to overlook new converters and forget them in the table. The relevant queries have now been made dynamic and everything has been tested to make sure there is no change. I still need to update the G(electricity_production) in the input excel since it is missing a few queries. Furthermore I'm going to spend some time cleaning up these types of groups. Currently we have a lot of groups defined in the queries and some are also redundant.

cjlaumans commented 12 years ago

I'm closing this ticket. The table and chart are consistent with each other, but there are still some things that can use improvement. But those are matters for a different ticket.