quintel / refinery

Calculates node demands and edge shares for sparse energy graphs.
2 stars 0 forks source link

Implement time curves in Refinery #35

Closed wmeyers closed 11 years ago

wmeyers commented 11 years ago

Split off from #25.

We need to add the start_year of the dataset to area.ad for now. Refinery should then be able to use this in finding out which value to take from a timecurve.

@antw, can you give an indication of when this will be implemented? If it won't be finished today I will ask @StijnDellaert to provide hard values in the nodes with time curves for now, so that we can continue with calculating the graph.

StijnDellaert commented 11 years ago

@wouterterlouw already tested with setting hard values for the time curve nodes, perhaps he can push his changes if necessary.

antw commented 11 years ago

can you give an indication of when this will be implemented? If it won't be finished today [...]

@wmeyers and I discussed this over Skype, but for the sake of everyone else: I would expect this to be done at some point tomorrow, since flex-max and green gas conversion is the immediate priority.

You can already write queries using the TIME_CURVE function, but know that until I implement it properly it will always return 0.0.

wmeyers commented 11 years ago

@wouterterlouw, Did it lead to good results? If so for now @wouterterlouw can maybe push those hard values he tested with. I would just leave the queries with the time curves commented out (with #'s in front of it), so that later it's easy to change back to time curves once implemented.

wouterterlouw commented 11 years ago

@wmeyers It does solve some converters, but not that much since the distribution converters does not function well. I will push the hard values anyway.

StijnDellaert commented 11 years ago

I'm working on the distribution converter so this is helpful, thanks

wouterterlouw commented 11 years ago

Added with https://github.com/quintel/etsource/pull/370.

antw commented 11 years ago

The TIME_CURVE function has been implemented by quintel/atlas@467dca9f. I put the CSVs from Dropbox in ETSource data/datasets/nl/time_curves. Documentation is here

wouterterlouw commented 11 years ago

@antw Great!

Adapted in energy extraction nodes by https://github.com/quintel/etsource/pull/400.