search

quintel / refinery

Calculates node demands and edge shares for sparse energy graphs.
2 stars 0 forks source link

Output shares should be calculated by refinery #39

Closed StijnDellaert closed 11 years ago

StijnDellaert commented 11 years ago

I have strange errors in my locally calculated graph.

im

(calculable graph) It claims to know the value of energy_national_gas_network_natural_gas , but sets it to zero, while there are several non-zero demands linked to this converter...

Also, the energy_mixer_for_gas_power_fuel has a known demand and known child shares, but still it says that the crude oil child can not be calculated...

My only suggestion is that I messed things up with setting a value (0) from the energy balance for the energy_distribution_network_gas_loss converter. Since the loss is simultaneously defined as 0.11% of the distribution converter. However, this 0.11% "conversion-efficiency" should not have this old value..

wmeyers commented 11 years ago

My only suggestion is that I messed things up with setting a value (0) from the energy balance for the energy_distribution_network_gas_loss converter. Since the loss is simultaneously defined as 0.11% of the distribution converter. However, this 0.11% "conversion-efficiency" should not have this old value..

I guess Refinery should trip on that

wmeyers commented 11 years ago

Can you test it by removing the conversion efficiency?

StijnDellaert commented 11 years ago

How to solve this? we can find the 4 loss demands (heat, electricity, gas, crude oil) in the energy balance and want to use those values. So a new conversion efficiency should be calculated based on the loss and the total demand of the distribution converter. THis conversion efficiency should then be set and used in the ETM if demands change..

Ideas @ChaelKruip & @antw ?

@wmeyers , I can try that first. but those efficiencies will be needed by the ETM, I think

wmeyers commented 11 years ago

So are you saying this conversion needs a dynamic conversion effiiency, based on the current country and start year?

antw commented 11 years ago

I thought it was agreed that efficiencies would be "global", i.e. the same in every region? The import script which creates/updates the .ad files reads a number of efficiencies from the InputExcel YAML files for this reason; that's where the 0.11% comes from.

I'm not sure that explains why the gas network node has zero demand though. @StijnDellaert Can you push your changes to a GitHub branch at some point so I can find out what Refinery is doing?

StijnDellaert commented 11 years ago

Pushed to heat_network branch https://github.com/quintel/etsource/commit/2f6f753a2ba026fabc0a2b1e61df85ae3a741741

StijnDellaert commented 11 years ago

OK, the issue is that within a carrier group, the shares must add up to 1. I defined child shares that up to 1 but contain different carriers. This is not a problem of Refinery and @wouterterlouw and I will try to fix this.

wmeyers commented 11 years ago

Assigning @StijnDellaert

StijnDellaert commented 11 years ago

@wouterterlouw & me temporarily fixed the mixer conversion problem. It still seems that this loss thing is a problem though.

StijnDellaert commented 11 years ago

https://github.com/quintel/refinery/issues/23

wmeyers commented 11 years ago

Can this be closed? The loss issue is described in #40.

StijnDellaert commented 11 years ago

Yes, closing