Closed preksharai closed 3 years ago
Please rebase and resolve conflicts @preksharai
I have changed the url of picture. Kindly review it. I have committed the changes. I want to know that since my profile is not visible on the webpage..still should I paste the screenshot of the webpage in PR description?
On Mon, Oct 18, 2021, 09:02 Shashwat Jaiswal @.***> wrote:
@.**** requested changes on this pull request.
Good work, just last item:
In data.json https://github.com/quintessences/showcase/pull/20#discussion_r730546889:
@@ -90,6 +90,15 @@ "github":"https://github.com/", "linkedin":"http://www.linkedin.com/", "quote":"ALL IS WELL"
- },
- {
- "name": "PREKSHA RAI",
- "batch": 2022,
- "picture_url": "https://ibb.co/xmJyd2z",
This link is broken. Please correct and paste the webpage's screenshot in the PR description.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/quintessences/showcase/pull/20#pullrequestreview-781560809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBKTJOWRUWOWSVRGG2KO7DUHOINHANCNFSM5GAM5UQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Just added my information to data.json. Please, add hacktober label to it.