search

quintilesims / layer0

Build, Manage, and Deploy Your Applications
Apache License 2.0
44 stars 20 forks source link

Task Logs #370

Closed zpatrick closed 7 years ago

zpatrick commented 7 years ago

What does this pull request do? Adds the task logs method

How should this be tested? Swagger

Checklist

diemonster commented 7 years ago

This covers the case of gathering logs for a task's underlying container, but we also need to figure out how we can implement gathering additional log data for the ECS API itself, and whether that should be included within service logs or task logs or some other command: http://docs.aws.amazon.com/AmazonECS/latest/developerguide/logging-using-cloudtrail.html.

It sounds to me like the ECS API logs will require us to sort data in CloudTrail and correlate that to a task or service by userIdentity to make them useful.

Alternatively, we could say screw it and try to figure out a way to dump this all to Splunk ;)

diemonster commented 7 years ago

Moving the ECS API log discussion to here https://github.com/quintilesims/layer0/issues/371

zpatrick commented 7 years ago

@diemonster : let's try to get this and service logs merged before I begin work on adding/fixing the service model to have that metadata info

diemonster commented 7 years ago

@zpatrick what has been covered by manual testing at this point? All functionality?

zpatrick commented 7 years ago

@diemonster yes, I created a task and used swagger to test w/ all the params