Closed diemonster closed 7 years ago
There's an incoming change from zpatrick that uppercases all the properties e.g. client -> Client etc. If that is how we want it, might be a good chance to update the casing in this PR.
type TestCommandBase struct {
client *mock_client.MockClient
printer *printer.TestPrinter
resolver *mock_resolver.MockResolver
}
@sesh-kebab I'm fine with changing, although I'm not clear on why? Are other types expected to need access to those fields?
@diemonster yes, other types are expected to use those fields
@zpatrick @sesh-kebab Hmmm ok. That prevents merging this for the moment then as changing CommandBase
has cascading effects to everyone else.
What does this pull request do? consolidate the code from
base_test.go
totest_helpers.go
, as placing all test utils there makes more sense