274: Load Balancer provider/aws unit tests

quintilesims / layer0

Build, Manage, and Deploy Your Applications

Apache License 2.0

44 stars 20 forks source link

274: Load Balancer provider/aws unit tests #410

Closed jparsons04 closed 6 years ago

jparsons04 commented 6 years ago

What does this pull request do? Adds unit tests for load balancer entity-actions

Checklist

[x] create
[x] delete
[x] list
[x] read
[x] update

Work towards #274

jparsons04 commented 6 years ago

So I've tried to implement quite a few things given the last PR comments:

1) A couple of helper functions in helpers.go to try to clean up some of the size of the unit tests 2) I've tried to favor hardcoding expected objects where possible 3) I've changed the casing within the defaults.go file

Unit tests still look good to me, but it could use another styling/formatting review pass @zpatrick @diemonster