search

quintilesims / layer0

Build, Manage, and Deploy Your Applications
Apache License 2.0
44 stars 20 forks source link

[v0.10.4] 475: Remove AWS Region default and require region for API operation #476

Closed jparsons04 closed 6 years ago

jparsons04 commented 6 years ago

What does this pull request do? Removes DEFAULT_AWS_REGION and requires that the environment variable LAYER0_AWS_REGION be specified when launching the L0 API

How should this be tested? Manually by running the L0 API locally. If LAYER0_AWS_REGION is not specified in your environment, the API will not run and you will be notified that the environment variable needs to be set.

Checklist ~- [ ] Unit tests~ ~- [ ] Smoke tests (if applicable)~ ~- [ ] System tests (if applicable)~ ~- [ ] Documentation (if applicable)~

closes #475 and #444

diemonster commented 6 years ago

@jparsons04 should we add this variable as part of l0-setup endpoint -d ?

jparsons04 commented 6 years ago

Ah, that's an interesting thought. Probably, yeah.