quintilesims / layer0

Build, Manage, and Deploy Your Applications
Apache License 2.0
44 stars 20 forks source link

596: Update AWS SDK vendoring #597

Closed jparsons04 closed 6 years ago

jparsons04 commented 6 years ago

Background

The vendored version of the AWS SDK is being updated to account for recent changes that have been made in the SDK. As it pertains to issue #596, ECS ContainerDefinitions have added new properties that we should support when l0 deploys are created, including the property LinuxParameters

How should this be tested?

{
    "AWSEBDockerrunVersion": 2,
    "containerDefinitions": [
        {
            "name": "guestbook",
            "image": "quintilesims/guestbook",
            "portMappings": [
                {
                    "hostPort": 80,
                    "containerPort": 80
                }
            ],
            "memory": 512,
            "linuxParameters": {
                "capabilities": {
                    "add": ["SYS_PTRACE"]
                }
            }
        }
    ],
    "essential": true
}

closes #596

jparsons04 commented 6 years ago

@sesh-kebab The specific approach I have taken to update the vendored version of the SDK was to execute the following: govendor fetch github.com/aws/aws-sdk-go/... to try to isolate dependencies to the project's directory tree.

zpatrick commented 6 years ago

Thanks @jparsons04 - will you DM me after you've built and pushed the binaries? I'd like to test with those before we announce this release