[DAE-113] Changing max_parts from get_partitions method to int32

felipemiquelim commented 3 years ago

Why? :open_book:

The max_parts parameter from get_partitions method was limiting our querying to 32k partitions.

What? :wrench:

Adjusting max_parts parameter from get_partitions method to handle 64k values.

Type of change :file_cabinet:

[X] Adjustment (non-breaking change)

How everything was tested? :straight_ruler:

Executed method get_partitions with the parameter as the new type and it allowed 60k as max_parts and returned the expected result.

Checklist :memo:

[X] I have added labels to distinguish the type of pull request.
[X] My code follows the style guidelines of this project (docstrings, type hinting and linter compliance);
[X] I have performed a self-review of my own code;
[X] I have made sure that new and existing unit tests pass locally with my changes;

felipemiquelim commented 3 years ago

My concern about changing these source files is that some update of the Thrift auto-generated code will overwrite this. Since we don't have another option better than this, I think we should have the changes like this one mapped somewhere so we can check after updating the thrift_files/*.

I can think of something like a checklist for updating the library inside the dir thrift_files/ or inside the readme. We can add the link of the PRs like this one that updates the library sources.

@LucasMMota - It makes total sense :bulb: , I will create the structure on a diff PR and link each other.