quinton-ashley / nostlan

Nostlan is a game launcher for emulators!
GNU General Public License v3.0
454 stars 23 forks source link

fullscreenKeyCombo not working for some emulators on Linux #47

Closed varlesh closed 2 years ago

varlesh commented 3 years ago

fullscreenKeyCombo not worked on Yuzu & Dolphin

    "dolphin": {
        "app": "org.DolphinEmu.dolphin-emu",
        "cmd": [
            "flatpak",
            "run",
            "${app}",
            "-e",
            "${game}"
        ],
        "fullscreenKeyCombo": [
            "f11"
        ]
    },
    "yuzu": {
        "cmd": [
            "flatpak",
            "run",
            "${app}",
            "${game}"
        ],
        "fullscreenKeyCombo": [
            "f11"
        ],
        "app": "org.yuzu_emu.yuzu"
    },

With Citra worked

varlesh commented 3 years ago

with Ryujinx not worked too. Maybe need added little sleep time for run fullscreenKeyCombo? I think it start before then emulator run

quinton-ashley commented 3 years ago

Which OS are you on? Yeah I should make it so Nostlan can know if the app has loaded. Not sure how to for some of the apps though.

varlesh commented 3 years ago

KDE Neon (Ubuntu 20.04)

quinton-ashley commented 3 years ago

Is the full screen key incorrect for those emulators on Linux or do you think it's just doing it at the wrong time?

varlesh commented 3 years ago

@quinton-ashley F11 not needed anymore:

fullscreen=true
fullscreen\default=false
varlesh commented 3 years ago

Is the full screen key incorrect for those emulators on Linux or do you think it's just doing it at the wrong time?

All keys use only F11 (i check it). Yes it's doing wrong time - before starting the emulator (i see how change fullscreen state on Nostlan)

quinton-ashley commented 3 years ago

thanks for that info! I'll update the cmd settings in core/emulators.js

quinton-ashley commented 3 years ago

@varlesh What's the default location for the qt-config.ini for Citra and config.json for Ryujinx?

varlesh commented 3 years ago

Fullscreen commands & configs:

Citra flatpak: fullscreen=true fullscreen\default=false ~/.var/app/org.citra_emu.citra/config/citra-emu/qt-config.ini

Ryujinx (not have flatpak version): "start_fullscreen": true, ~/.config/Ryujinx/Config.json

PCSX2 flatpak: DefaultToFullscreen=enabled ~/.var/app/net.pcsx2.PCSX2/config/PCSX2/inis/PCSX2_ui.ini

PPSSPP flatpak: FullScreen = True ~/.var/app/org.ppsspp.PPSSPP/config/ppsspp/PSP/SYSTEM/ppsspp.ini

Yuzu flatpak: flatpak run org.yuzu_emu.yuzu -f -g

Dolphin flatpak: flatpak run org.DolphinEmu.dolphin-emu --config "Dolphin.Display.Fullscreen=True"

Only melonDS not have this function, but available fixed fork for that with this artiifacts: https://github.com/Arisotura/melonDS/issues/237#issuecomment-889533716

other emulators have not been investigated

quinton-ashley commented 3 years ago

Thanks for this research!! I'll implement these in the next version of Nostlan.

varlesh commented 3 years ago

upd PCSX2 have command line option: flatpak run net.pcsx2.PCSX2 --fullscreen --nogui

varlesh commented 3 years ago

RPCS3: Start games in fullscreen mode: true ~/.var/app/net.rpcs3.RPCS3/config/rpcs3/config.yml

and run with no gui mode: flatpak run net.rpcs3.RPCS3 --no-gui