search

quinton-ashley / p5play-web

The website for p5play.org
17 stars 13 forks source link

Addressing #31 #34

Closed ShiMeiWo closed 3 months ago

ShiMeiWo commented 3 months ago

I edited the lang/build.js . Please let me know if there are any undesirable implementations.

quinton-ashley commented 3 months ago

excellent work on this, thank you!

quinton-ashley commented 3 months ago

I also think you should add a translator credit to yourself in the footer section of each page! You could include a link for people to contact you as well.

Edit the "ft" section at the bottom of lang/ja/index.md and also learn.DOM.credits in the ja.json

ShiMeiWo commented 3 months ago

@quinton-ashley Thank you for your kind offer. However, I would still like to request that you wait for the addition of my name to the credits section. I would appreciate a little more time for my name to be added to the credits section, as the issue with the smartphone display has not yet been resolved (a overhang to the top and bottom):

Screenshot_20240418-145104523.png

Screenshot_20240418-145239561.png

I will raise an issue regarding this matter this evening (Japan time). Once the determination of a resolution policy and it's implementation for the issue are finished, I will kindly ask you to please wait until then.