search

quintush / helm-unittest

BDD styled unit test framework for Kubernetes Helm charts as a Helm plugin.
MIT License
344 stars 69 forks source link

removed -s. Invalid option for sha256sum #73

Closed snachiap closed 3 years ago

snachiap commented 4 years ago

Hi,

While installing the plugin to centos, checksum validation fails with the below error

Screenshot 2020-10-15 at 14 22 50

The install binary sh file was updated to fix the issue.

I don't have a go environment setup, so unable to test the complete installation, but still tested the checksum validation part which was successful in Centos.

Thanks and incase the update the not correct, please help to fix the installation issue

quintush commented 4 years ago

Hello @snachiap ,

Thanks for the update. I will verify if the options also works for other linux versions.

Creating a good installation for all distributions is maybe one of the hardest parts to accomplish.

Greetings, @quintush

snachiap commented 4 years ago

Thank you very much for the prompt response.

quintush commented 3 years ago

It has been a while, but finally managed to verify several scenarios.

Only removing the -s option does fix the error, but does not fix the goal to be achieved. The -s options makes sure that the exitcode is different when a invalid sha checksum is calculated.

I have created a fix, which still resolves your issue on CentOS and manage to keep the goal on validating the sha checksum.