quintype / quintype-amp

Quintype's AMP component library for publisher apps to create amp layouts

0 stars 1 forks source link

Fix: Add fallback to poster images in visual story template #419

Closed shraddha-kesari closed 1 year ago

shraddha-kesari commented 1 year ago

Description

Fix Amp errors if image element is not adding to visual story template when video element is added.

Fixes # (issue-reference)

Added fallback as hero image

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Create a visual story, add hero image, add video element first card and publish.
It shouldn't throw any errors and poster should pick up hero image as fallback

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules