quintype / quintype-amp

Quintype's AMP component library for publisher apps to create amp layouts
0 stars 1 forks source link

[feat]: Add render Prop to Footer Component #432

Closed shraddha-kesari closed 1 year ago

shraddha-kesari commented 1 year ago

Description

At present, footer can be customised with only text and background colour. Many clients came up asking for more customisations. So, we decided to add a render prop to footer which will accept component.

Dependencies # (dependency-issue-reference) Update framework version to get this change in frontend.

Documentation # (link to the corresponding documentation changes) Yes. Documentation needs to updated with new render prop

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

  1. Pass a custom component or div to the render prop in frontend app. And check whether it is reflecting it the frontend in place of footer.
  2. If not passed, default footer should render.

Checklist:

devasenamurugesan commented 1 year ago

custom-footer-amp-11550 - Build had issue with - internal server error. After the fix

custom-footer-amp-11564 - It is working as expected.