quintype / quintype-amp

Quintype's AMP component library for publisher apps to create amp layouts

0 stars 1 forks source link

Focus point not set on HeroImage in Amp stories #442

Closed VeenaYemmiganur closed 1 year ago

VeenaYemmiganur commented 1 year ago

Description

Currently , if AspectRatio is not passed, under AMP stories, the image height is taken from metadata , not cropping as per focus point;

Fixes # (issue-reference) https://github.com/quintype/ace-planning/issues/857

Type of change

Please delete options that are not relevant.

[ X ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Checklist:

[ X ] My code follows the style guidelines of this project
[ X ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ X ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules