search

quiph / RecyclerView-FastScroller

A fully customizable Fast Scroller for the RecyclerView in Android, written in Kotlin
Apache License 2.0
855 stars 70 forks source link

Orientation Support? #3

Closed rgocal closed 3 years ago

rgocal commented 5 years ago

Does this fastscroller support Horizontal and Vertical Recyclerviews?

shahsurajk commented 5 years ago

As you can see the todo, it's not yet planned, but it's definitely going to be implemented someday. For now it only supports vertical recyclerviews.

rgocal commented 5 years ago

Alright, thank you for the reply. Im looking for a fastscroll for a launcher app drawer that supports orientation.

gilgoldzweig commented 5 years ago

Is there a reason for not appending it as part of the LayoutManager?

That seems like a better way to add support for basically any direction

shahsurajk commented 5 years ago

Interesting, it didn't hit me. But could you elaborate your solution, as in what would you do? Are you hinting layoutManager.orientation = RecyclerView.HORIZONTAL? cause i think we can totally do that!

gilgoldzweig commented 5 years ago

Yeah, something in that realm.

shahsurajk commented 5 years ago

Yeah, we can do this, just need to figure out a bit of math, so currently there is an attribute to do this, fastScrollDirection this will simply be deprecated and the fastscroller will internally use the orientation provided in the LayoutManager but we still have to port the code to make it work in the horizontal direction.

shahsurajk commented 4 years ago

@tom5079 you'll have to also add "Fixes #3" in your last commit message for #29

shahsurajk commented 3 years ago

@tom5079 , it didn't close this issue, manually closing it.

fixed with: https://github.com/quiph/RecyclerView-FastScroller/releases/tag/v1.0.0

tom5079 commented 3 years ago

@shahsurajk ok to be honest I'm confused by it now