search

quiph / RecyclerView-FastScroller

A fully customizable Fast Scroller for the RecyclerView in Android, written in Kotlin
Apache License 2.0
855 stars 70 forks source link

FastScroll Padding? #5

Closed MrZ3T4 closed 3 years ago

MrZ3T4 commented 4 years ago

Is there a way to set an upper and lower margin without affecting the recyclerview?

Since at the end of the scroll it is not possible to reach the last item and it must slide out of view :/

shahsurajk commented 4 years ago

No, not yet. This could be a good first issue for people to work on.

dhruvnagarajan commented 4 years ago

@MrZ3T4 Won't clipToPadding solve this issue?

shahsurajk commented 4 years ago

@dhruvnagarajan i'm not sure how it would help, do you have an implementation in mind?

dhruvnagarajan commented 4 years ago

Since at the end of the scroll it is not possible to reach the last item and it must slide out of view :/

This is not entirely clear.

It appears that @MrZ3T4 is having an overlap of views towards the bottom of the list, so I recommended use of padding for the last item.

shahsurajk commented 4 years ago

@tom5079 Let's amend the commit message for #30 with "Fixes #5"

tom5079 commented 4 years ago

@shahsurajk I said i'll reopen that issue after #29 is merged. Pull requests after #30 is an entangled mess, so I need to cherrypick commits

shahsurajk commented 4 years ago

got it, what i meant @tom5079 is let's amend the commit message with a "fixes .. " message, like something mentioned here: https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue. so, this will auto close the issue once the commit is merged to master.

tom5079 commented 4 years ago

uh... "resolves" does the same thing too...

shahsurajk commented 4 years ago

@tom5079 , yes, resolves works too, but you'll have to write that in the commit message. :)

tom5079 commented 4 years ago

it doesn't have to be in the commit message, it works when it's on the PR comment. check this out image

shahsurajk commented 4 years ago

it does, though i'm not sure if it will auto-close the issue once the PR is merged. will it?

tom5079 commented 4 years ago

I guess it will, but not 100% sure. wanna test it?

tom5079 commented 4 years ago

@shahsurajk Turns out that it does close the issue. check https://github.com/tom5079/PR keep in mind that it only closes the issue when the PR is merged to master branch

shahsurajk commented 4 years ago

@tom5079 , yes. got to know of it now as well: https://stackoverflow.com/a/15827689/4820556. Though it used to be based only on commit messages early on. My bad here. :beer:

tom5079 commented 4 years ago

all good 😄

shahsurajk commented 3 years ago

fixed with https://github.com/quiph/RecyclerView-FastScroller/releases/tag/v1.0.0