quipo / statsd

Golang StatsD client
MIT License
164 stars 51 forks source link

PrecisionTiming avg,cnt,min,max treated as 'ms', should be 'g'? #29

Open ericmort opened 8 years ago

ericmort commented 8 years ago

We use Collectd to collect the timing stats, and it automatically calculates averages++ based on the timing events from statsd. But because statsd already calculates avg,cnt, max and min before sending the data, we end up with events like x.x.avg.avg, x.x.avg.cnt etc. instead of simply x.x.avg. I am no expert on the StatsD protocol or anything, but are averages, counts etc. really 'timing' measurements?

As it is, we have had to change our version of quipo/statsd so that the PrecisionTiming.Statsd function prints 'c' for count and 'g' instead of 'ms' to get correct measurements.

I wonder if this should be incorporated into the base code somehow?

quipo commented 7 years ago

is this something that depends on Collectd's configuration?