Optimize: Replacing string formatting with concatenation

[agnivade]

• The metric line format of "%s%s:%s" can be constructed by simple string concatenation which turns out to be significantly faster and costs zero memory.

Benchmarks show clear improvement -

func BenchmarkStringSprintf(b *testing.B) {
    w1 := "hello"
    w2 := "world"
    w3 := "fd"
    for n := 0; n < b.N; n++ {
        fmt.Sprintf("%s%s:%s", w1, w2, w3)
    }
}

func BenchmarkStringConcat(b *testing.B) {
    w1 := "hello"
    w2 := "world"
    w3 := "fd"
    for n := 0; n < b.N; n++ {
        _ = w1 + w2 + ":" + w3
    }
}

BenchmarkStringSprintf-4     5000000           338 ns/op          64 B/op          4 allocs/op
BenchmarkStringConcat-4     30000000            40.3 ns/op         0 B/op          0 allocs/op
PASS
ok      stdtest 3.303s

[agnivade]

Hi @quipo - Any updates on this ? Thanks.

[quipo]

Thanks @agnivade!