quipuapp / quipu-api-php

Official PHP client for the Quipu API
GNU General Public License v3.0
0 stars 1 forks source link

base64 encode creds #7

Closed shadimanna closed 1 year ago

shadimanna commented 1 year ago

Looks good.

It is strange that we didn't encode this in Base64 before, did it ever work?

Plus, I would remove the commented line, it is useless now and we always have git history if we needed.

Agreed, I have removed commented line and will merge.