search

quipucords / rho

A tool for scanning a network, logging into systems using SSH, and retrieving information about available Unix and Linux servers.
https://quipucords.github.io/rho/
GNU General Public License v2.0
5 stars 7 forks source link

Add 30 minute timeout to host discovery phase #555

Closed noahl closed 6 years ago

noahl commented 6 years ago

Closes #551 .

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.07%) to 62.55% when pulling 694bdf62ef0646970d1d5400f2f79300a5ed352e on issues/551 into 165af9616daf041f94579382b8766c79bc8d3e30 on master.

noahl commented 6 years ago

@chambridge just uploaded a new version that uses pexpect timeouts. Please take a look.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 62.483% when pulling 986eb96f7d5977c32ccb12ffac5e32854e5bd3e6 on issues/551 into 165af9616daf041f94579382b8766c79bc8d3e30 on master.

noahl commented 6 years ago

@chambridge GitHub thinks you still have an outstanding request for changes. Would you mind dismissing it if it's all done and then we can merge this?

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 62.483% when pulling 573d5870d185b3909f3b5fbceaf185f7ca5e3934 on issues/551 into 165af9616daf041f94579382b8766c79bc8d3e30 on master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 62.483% when pulling 573d5870d185b3909f3b5fbceaf185f7ca5e3934 on issues/551 into 165af9616daf041f94579382b8766c79bc8d3e30 on master.

noahl commented 6 years ago

@chambridge I don't know if you did something or if I saw something different earlier, but this looked fine on GitHub, and since you had approved it, I merged. Please let me know if there's something I missed.