quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

Remove legacy code from yupana (HTTP/ local templates) #277

Closed abaiken closed 4 years ago

abaiken commented 4 years ago

Closes #264

codecov-io commented 4 years ago

Codecov Report

Merging #277 into master will decrease coverage by 2.09%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #277     +/-   ##
=========================================
- Coverage   94.73%   92.64%   -2.1%     
=========================================
  Files          29       19     -10     
  Lines        2452     1264   -1188     
  Branches      286      140    -146     
=========================================
- Hits         2323     1171   -1152     
+ Misses         84       70     -14     
+ Partials       45       23     -22
Impacted Files Coverage Δ
yupana/api/serializers.py 100% <ø> (ø) :arrow_up:
yupana/processor/report_slice_processor.py 92.12% <ø> (ø) :arrow_up:
yupana/api/models.py 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac19705...fa167bd. Read the comment docs.

myersCody commented 4 years ago

@abaiken

I was wondering if you thought that my pr to switch local development over to insights-ingress-go would affect the test if local deployment works scenario of this pr? After looking through the code I am pretty confident that it won't, but I just wanted to check with you to make sure.

abaiken commented 4 years ago

@myersCody your PR should not affect this. This PR is just removing legacy code and settings. The only thing that has changed about local development is that it always uses KAFKA to upload hosts to HBI, so you no longer need a couple of environment variables since you don't have the choice to use HTTP.

myersCody commented 4 years ago

I think our secret.env.dev.example is missing some of the environment variables we need to run openshift.

I think we are missing:

DATABASE_NAME
DATABASE_ADMIN_PASSWORD
DATABASE_SERVICE_CERT
DJANGO_SECRET_KEY
NAME

UPDATE: Talked to ash, and these vars are defined inside of the secret.yaml.