quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

Fix DATABASE_SERVICE_NAME in e2e-deploy templates #281

Closed abaiken closed 4 years ago

abaiken commented 4 years ago

Bug Description:

The database service name value for prod postgres_sql is preventing successful deployments to production due to it invalidating the template because it fails the regex check due to the underscore.

INFO:ocdeployer.utils: |stderr| The DeploymentConfig "yupana" is invalid:
INFO:ocdeployer.utils: |stderr| * spec.template.spec.containers[0].env[0].valueFrom.secretKeyRef.name: Invalid value: "postgres_sql": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
INFO:ocdeployer.utils: |stderr| * spec.template.spec.containers[0].env[1].valueFrom.secretKeyRef.name: Invalid value: "postgres_sql": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
INFO:ocdeployer.utils: |stderr| * spec.template.spec.containers[0].env[3].valueFrom.secretKeyRef.name: Invalid value: "postgres_sql": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')
ERROR:ocdeployer.utils:Command failed!  Aborting.

Expected behavior:

We should be able to successfully deploy to production.

Actual behavior:

A successful deployment is prevented since the template is declared invalid.

Steps to reproduce:

Deploy to production via jenkins and look at the console output.


Acceptance Criteria: