search

quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

Supress logging of sensitive info #325

Closed patilsuraj767 closed 4 years ago

patilsuraj767 commented 4 years ago

This change will help to mask sensitive information like CW_AWS_SECRET_ACCESS_KEY and DJANGO_SECRET_KEY.

codecov-commenter commented 4 years ago

Codecov Report

Merging #325 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files          20       20           
  Lines        1300     1300           
  Branches      142      142           
=======================================
  Hits         1205     1205           
  Misses         72       72           
  Partials       23       23
Impacted Files Coverage Δ
yupana/api/status/model.py 98.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d98a0eb...849109e. Read the comment docs.

kgaikwad commented 4 years ago

@patilsuraj767, could you please rebase your branch with latest master?

ShimShtein commented 4 years ago

Not tested, but the code looks good. :+1: from me.

kgaikwad commented 4 years ago

Thank you @patilsuraj767, @beav & @ShimShtein!