quipucords / yupana

Service app to process & upload data from quipucords and satellite to the host based inventory
GNU General Public License v3.0
4 stars 14 forks source link

Avoid processing older reports #327

Closed patilsuraj767 closed 3 years ago

patilsuraj767 commented 4 years ago

With this PR report_consumer will check the expiry of minio url and will not process the report if the link is expired.

codecov-commenter commented 4 years ago

Codecov Report

Merging #327 into master will decrease coverage by 0.07%. The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   92.69%   92.61%   -0.08%     
==========================================
  Files          20       20              
  Lines        1300     1313      +13     
  Branches      142      144       +2     
==========================================
+ Hits         1205     1216      +11     
- Misses         72       73       +1     
- Partials       23       24       +1     
Impacted Files Coverage Δ
yupana/processor/report_consumer.py 70.07% <85.71%> (+1.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d98a0eb...1b5fad1. Read the comment docs.

codecov-io commented 4 years ago

Codecov Report

Merging #327 (9be0a00) into master (dc22476) will decrease coverage by 0.08%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   93.97%   93.88%   -0.09%     
==========================================
  Files          20       20              
  Lines        1360     1342      -18     
  Branches      153      149       -4     
==========================================
- Hits         1278     1260      -18     
  Misses         58       58              
  Partials       24       24              
Impacted Files Coverage Δ
yupana/processor/report_consumer.py 75.59% <100.00%> (+2.78%) :arrow_up:
yupana/processor/report_slice_processor.py 93.49% <0.00%> (-1.01%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc22476...6a63bff. Read the comment docs.

ShimShtein commented 4 years ago

ACK from me, although this needs a rebase.

kgaikwad commented 3 years ago

Thanks @patilsuraj767!