Closed patilsuraj767 closed 3 years ago
Merging #327 into master will decrease coverage by
0.07%
. The diff coverage is85.71%
.
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 92.69% 92.61% -0.08%
==========================================
Files 20 20
Lines 1300 1313 +13
Branches 142 144 +2
==========================================
+ Hits 1205 1216 +11
- Misses 72 73 +1
- Partials 23 24 +1
Impacted Files | Coverage Δ | |
---|---|---|
yupana/processor/report_consumer.py | 70.07% <85.71%> (+1.65%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d98a0eb...1b5fad1. Read the comment docs.
Merging #327 (9be0a00) into master (dc22476) will decrease coverage by
0.08%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #327 +/- ##
==========================================
- Coverage 93.97% 93.88% -0.09%
==========================================
Files 20 20
Lines 1360 1342 -18
Branches 153 149 -4
==========================================
- Hits 1278 1260 -18
Misses 58 58
Partials 24 24
Impacted Files | Coverage Δ | |
---|---|---|
yupana/processor/report_consumer.py | 75.59% <100.00%> (+2.78%) |
:arrow_up: |
yupana/processor/report_slice_processor.py | 93.49% <0.00%> (-1.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dc22476...6a63bff. Read the comment docs.
ACK from me, although this needs a rebase.
Thanks @patilsuraj767!
With this PR report_consumer will check the expiry of minio url and will not process the report if the link is expired.